Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbt 1.0.4 #666

Closed
wants to merge 1 commit into from
Closed

sbt 1.0.4 #666

wants to merge 1 commit into from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Dec 5, 2017

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #666 into develop will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #666      +/-   ##
===========================================
- Coverage    71.93%   71.83%   -0.11%     
===========================================
  Files          707      707              
  Lines        22543    22543              
  Branches      1716     1715       -1     
===========================================
- Hits         16216    16193      -23     
- Misses        6327     6350      +23
Impacted Files Coverage Δ
...le/http2/transport/PriorKnowledgeTransporter.scala 57.14% <0%> (-28.58%) ⬇️
...ain/scala/com/twitter/finagle/tracing/Tracer.scala 62.19% <0%> (-10.98%) ⬇️
...inagle/http2/transport/UpgradeRequestHandler.scala 85.29% <0%> (-5.89%) ⬇️
...itter/finagle/http2/LoggerPerFrameTypeLogger.scala 37.03% <0%> (-1.86%) ⬇️
...rc/main/scala/com/twitter/finagle/mux/Server.scala 93.33% <0%> (-0.75%) ⬇️
...nagle/http2/transport/MultiplexedTransporter.scala 76% <0%> (-0.5%) ⬇️
...agle/http2/transport/Http2UpgradingTransport.scala 92.85% <0%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63186f...0631c8a. Read the comment docs.

@kevinoliver
Copy link
Contributor

cc @mosesn

@mosesn
Copy link
Contributor

mosesn commented Dec 5, 2017

@sullis is there an sbt 1.0.4 feature you'd like to use? we prefer to keep our sbt versions in sync, so if there isn't anything you need, we might not want to upgrade this immediately.

@sullis
Copy link
Contributor Author

sullis commented Dec 5, 2017

SBT 1.0.4 fixes a performance issue in SBT 1.0.3
https://developer.lightbend.com/blog/2017-11-27-sbt-1-0-4-hotfix-and-performance-fixes/

@cacoco
Copy link
Contributor

cacoco commented Dec 20, 2017

@sullis sbt 1.0.4 introduces a scala compilation regression that fails for one of our other projects (Scrooge). The regression was patched in 1.0.3 but looks like they didn't apply it to 1.0.4 before releasing.

This is the issue: sbt/zinc#127

@sullis
Copy link
Contributor Author

sullis commented Feb 19, 2018

obsolete

@sullis sullis closed this Feb 19, 2018
@sullis sullis deleted the sbt-1.0.4 branch February 19, 2018 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sullis @codecov-io @kevinoliver @mosesn @cacoco